merrimanr commented on issue #1374: METRON-2061: Solr documents with date fields cannot be updated with Dao classes URL: https://github.com/apache/metron/pull/1374#issuecomment-501459998 I was under the impression all checkboxes need to be done before a PR is complete. You can assume an empty bracket means it's pending. To be clear, the global config patch is unaffected by this change. The only thing affected is the REST Patch endpoint. I'm assuming you are ok with the solution I chose (number 2 in the PR description)? I agree that your suggestion (number 1) is ideal. Think the only thing missing from https://tools.ietf.org/html/rfc6902 is the "test" operation which is easy enough to add. I will proceed with writing tests for all scenarios in https://tools.ietf.org/html/rfc6902.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
