mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r311143515
##########
File path:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java
##########
@@ -241,10 +241,18 @@ public SaltyRowKeyBuilder(int saltDivisor, long
duration, TimeUnit units) {
}
}
+ public long getPeriodDurationMillis() {
+ return periodDurationMillis;
+ }
+
public void withPeriodDuration(long duration, TimeUnit units) {
periodDurationMillis = units.toMillis(duration);
}
+ public int getSaltDivisor() {
Review comment:
I understand it's not related to enrichments, however there are some
common/standard practices with HBase, e.g. salting, that are common to both.
This is legacy code, so I recant my earlier request to have this done before
the upgrade is finished. My only ask would be to potentially create a Jira out
of band from the FB that calls out something like "Reconcile/refactor common
hbase idioms in code base"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
