mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r311258638
##########
File path:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java
##########
@@ -241,10 +241,18 @@ public SaltyRowKeyBuilder(int saltDivisor, long
duration, TimeUnit units) {
}
}
+ public long getPeriodDurationMillis() {
+ return periodDurationMillis;
+ }
+
public void withPeriodDuration(long duration, TimeUnit units) {
periodDurationMillis = units.toMillis(duration);
}
+ public int getSaltDivisor() {
Review comment:
This seems like an exploratory Jira, first. The salting would have come
along with some of the LookupKV stuff, I'd imagine. I haven't been in there a
while aside from reviewing the HBase upgrade PRs - did you not come across any
of that while doing the upgrade? I can't imagine it could have been avoided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
