nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r311217301
########## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileGenerator.java ########## @@ -0,0 +1,106 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.metron.profiler.client; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.metron.hbase.client.HBaseTableClient; +import org.apache.metron.hbase.client.HBaseClient; +import org.apache.metron.hbase.client.HBaseConnectionFactory; +import org.apache.metron.profiler.ProfileMeasurement; +import org.apache.metron.profiler.ProfilePeriod; +import org.apache.metron.profiler.hbase.ColumnBuilder; +import org.apache.metron.profiler.hbase.RowKeyBuilder; +import org.apache.metron.profiler.hbase.SaltyRowKeyBuilder; +import org.apache.metron.profiler.hbase.ValueOnlyColumnBuilder; + +import java.util.Collections; +import java.util.List; +import java.util.Random; +import java.util.concurrent.TimeUnit; +import java.util.function.Function; + +/** + * Generates a profile by writing multiple sequential {@link org.apache.metron.profiler.ProfileMeasurement} + * values. This is useful for generating profiles to be read during testing. + */ +public class ProfileGenerator { + + private ProfileWriter profileWriter; + + public ProfileGenerator(ProfileWriter profileWriter) { + this.profileWriter = profileWriter; + } + + /** + * Generates a profile by writing multiple sequential {@link org.apache.metron.profiler.ProfileMeasurement} + * values based on a single prototype. + * + * @param prototype A prototype for the types of ProfileMeasurements that should be written. + * @param count The number of profile measurements to write. + * @param group The name of the group. + * @param valueGenerator A function that consumes the previous ProfileMeasurement value and produces the next. + */ + public void generate(ProfileMeasurement prototype, + int count, + List<Object> group, + Function<Object, Object> valueGenerator) { + ProfileMeasurement m = prototype; + ProfilePeriod period = m.getPeriod(); + for(int i=0; i<count; i++) { + // generate the next value that should be written + Object nextValue = valueGenerator.apply(m.getProfileValue()); + + // write the measurement + m = new ProfileMeasurement() + .withProfileName(prototype.getProfileName()) + .withEntity(prototype.getEntity()) + .withPeriod(period) + .withGroups(group) + .withProfileValue(nextValue); + profileWriter.write(m); + + // advance to the next period + period = m.getPeriod().next(); + } + } + + public static void main(String[] args) throws Exception { Review comment: This is actually legacy code that allowed us to backfill profiles from the command-line for testing purposes. When the Batch Profiler was introduced this should have been killed. We don't need the `main` any longer. The `ProfileGenerator`, `ProfileWriter' and `HBaseProfileWriter` were refactorings on this legacy functionality when I thought I might need "write" functionality for the `HBaseClient` API. After additional work I found this not be necessary. I removed these unnecessary classes in commit 3e825c1cf. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
