nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r311277636
########## File path: dependencies_with_url.csv ########## @@ -146,6 +146,7 @@ com.codahale.metrics:metrics-core:jar:3.0.2:compile,MIT,https://github.com/codah com.codahale.metrics:metrics-graphite:jar:3.0.2:compile,MIT,https://github.com/codahale/metrics com.esotericsoftware.reflectasm:reflectasm:jar:shaded:1.07:compile,BSD,https://github.com/EsotericSoftware/reflectasm com.fasterxml.jackson.core:jackson-annotations:jar:2.2.3:compile,ASLv2,http://wiki.fasterxml.com/JacksonHome +com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:compile,ASLv2,http://wiki.fasterxml.com/JacksonHome Review comment: Actually, jackson-databind:2.7.4, which is the version defined by `${global_jackson_version}` pulls in jackson-annotations:2.7.0, so this seems to be a necessary dependency. The only remotely related changes is that I had to add the `jackson-databind` dependency to `metron-profiler-storm`. But I am just pulling it in explicitly, just like many other projects already do; `metron-parsers-common`, `metron-enrichment-storm`, `stellar-common`. I am not sure why the license validator did not pick-up on this dependency before, since the same dependency lives in many other projects. Hmm. ``` @ ~/Development/metron/metron-analytics/metron-profiler-storm $ mvn dependency:tree [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building metron-profiler-storm 0.7.2 [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ metron-profiler-storm --- [INFO] org.apache.metron:metron-profiler-storm:jar:0.7.2 [INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.4:compile [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:compile [INFO] | \- com.fasterxml.jackson.core:jackson-core:jar:2.7.4:compile ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
