nickwallen commented on a change in pull request #1490: METRON-2169: Upgrade Kafka/Storm URL: https://github.com/apache/metron/pull/1490#discussion_r316846976
########## File path: pom.xml ########## @@ -154,16 +155,25 @@ <hdp_version>2.6.5.0</hdp_version> <global_hbase_version>1.1.1</global_hbase_version> <global_hbase_guava_version>12.0</global_hbase_guava_version> + <!--<global_kafka_version>0.10.0.1</global_kafka_version>--> + <!--<global_slf4j_version>1.7.7</global_slf4j_version>--> + <global_kafka_version>2.0.0</global_kafka_version> + <global_slf4j_version>1.7.25</global_slf4j_version> + <global_storm_version>1.2.1</global_storm_version> </properties> </profile> <profile> <id>HDP-2.5.0.0</id> <properties> <hdp_version>2.5.0.0</hdp_version> <build_number>1245</build_number> - <global_storm_kafka_version>1.2.2</global_storm_kafka_version> - <global_storm_version>${base_storm_version}.${hdp_version}-${build_number}</global_storm_version> - <global_kafka_version>${base_kafka_version}.${hdp_version}-${build_number}</global_kafka_version> + <!--<global_storm_kafka_version>1.2.2</global_storm_kafka_version>--> + <!--<global_storm_version>${base_storm_version}.${hdp_version}-${build_number}</global_storm_version>--> + <!--global_kafka_version>${base_kafka_version}.${hdp_version}-${build_number}</global_kafka_version--> + <!--global_slf4j_version>1.7.7</global_slf4j_version--> Review comment: Should we leave the existing HDP-2.5.0.0 profile as-is until we can remove it as a separate PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services