nickwallen commented on a change in pull request #1490: METRON-2169: Upgrade
Kafka/Storm
URL: https://github.com/apache/metron/pull/1490#discussion_r316850176
##########
File path:
metron-platform/metron-integration-test/src/main/java/org/apache/metron/integration/components/KafkaComponent.java
##########
@@ -137,13 +141,20 @@ public String getBrokerList() {
return createProducer(String.class, byte[].class);
}
+ public AdminClient createAdminClient() {
+ Map<String, Object> adminConfig = new HashMap<>();
+ adminConfig.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG,
getBrokerList());
+ AdminClient adminClient = KafkaAdminClient.create(adminConfig);
Review comment:
Based on my reading of the
[Javadocs](https://kafka.apache.org/20/javadoc/org/apache/kafka/clients/admin/KafkaAdminClient.html),
we should not refer directly to `KafkaAdminClient`. Just refer to
`AdminClient` instead.
```
AdminClient adminClient = AdminClient.create(adminConfig);
```
> KafkaAdminClient
> The default implementation of AdminClient. An instance of this class is
created by invoking one of the create() methods in AdminClient. Users should
not refer to this class directly. The API of this class is evolving, see
AdminClient for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
