mmiklavc commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533268931
 
 
   @merrimanr This is pretty complicated so I want to talk through this a bit 
and make sure this is clear. 
   
   It looks like the upshot is that previously the functionality only depended 
on shared state in Zookeeper. You could reference a `ServiceDiscoveryImpl` in 2 
separate processes (1 in the integration test process, the other in the 
application master container process spawned by YARN) with no issue. Now, the 
internal map matters, but unlike the zookeeper path this state is not 
distributed. So that verification fails when there's no item in the internal 
map.
   
   The integration test creates a `ServiceDiscover` here 
https://github.com/apache/metron/blob/master/metron-analytics/metron-maas-service/src/test/java/org/apache/metron/maas/service/MaasIntegrationTest.java#L218
   
   The YARN app creates a `ServiceDiscover` here when it creates the 
`ContainerRequestListener ` 
https://github.com/apache/metron/blob/master/metron-analytics/metron-maas-service/src/main/java/org/apache/metron/maas/service/ApplicationMaster.java#L454

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to