mmiklavc commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0 URL: https://github.com/apache/metron/pull/1516#issuecomment-533296308 > Almost all correct. There are other `ServiceDiscoverer` instances created [here](https://github.com/apache/metron/blob/master/metron-analytics/metron-maas-service/src/main/java/org/apache/metron/maas/service/runner/Runner.java#L193) and [here](https://github.com/apache/metron/blob/master/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/functions/MaaSFunctions.java#L229). Here's what each one does: > > `MaasIntegrationTest` - Used to test which endpoints are registered. Runs in test. > `MaaSFunctions` - Used to get endpoint. Runs in a Stellar context. > `Runner` - Registers service endpoint when container starts. Runs in model container. > `ContainerRequestListener ` - Unregisters services based on container callbacks. Runs in app master. Oh, that's actually more than I thought without having run the lookup on uses. Glad I asked. One manual test we might want to add is attempting to remove a non-existent endpoint. Looking at the code, I don't see a whole lot of risk in the "add then remove" approach other than if the operation were to fail in between add/remove. For a service that doesn't exist, you could end up with an item in zookeeper that doesn't actually exist.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
