mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile
Versions in Root POM with HDP 3.1
URL: https://github.com/apache/metron/pull/1551#discussion_r344326846
##########
File path: pom.xml
##########
@@ -185,11 +167,6 @@
<artifactId>mockito-core</artifactId>
<version>${global_mockito_version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.storm</groupId>
- <artifactId>storm-kafka</artifactId>
Review comment:
@justinleet @nickwallen - nope, looks like that was me -
https://github.com/mmiklavc/metron/blame/7f1160401897c49738dcb79609661419d39e112d/pom.xml#L116.
The way the dependency management section works is to lay down versions and
other details about a dependency so you can include it in your child projects
without having to explicitly specify the version. Ideally, this would be the
way we declare all shared dependencies in Metron. Submodules are free to
override the default if/when they choose by explicitly declaring the version in
their pom dep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
