mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile
Versions in Root POM with HDP 3.1
URL: https://github.com/apache/metron/pull/1551#discussion_r344327837
##########
File path: pom.xml
##########
@@ -185,11 +167,6 @@
<artifactId>mockito-core</artifactId>
<version>${global_mockito_version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.storm</groupId>
- <artifactId>storm-kafka</artifactId>
Review comment:
If this is not needed, then I think it's fine to remove it. We might
consider a separate task at some point of refactoring our poms to use this
idiom rather than having to leverage version properties all over. It should
clean up our poms considerably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
