justinleet commented on a change in pull request #1568: METRON-2324:
verify_licenses.sh and list_dependencies.sh don't properly handle maven failures
URL: https://github.com/apache/metron/pull/1568#discussion_r354473625
##########
File path: .travis.yml
##########
@@ -60,6 +60,7 @@ matrix:
- name: Verify Licenses
script:
+ - time mvn install -T 2C -q -DskipTests=true -Dmaven.javadoc.skip=true
-B -V -Dskip.npm
Review comment:
1. Just skips the UI portion of the build. it's already built-in. The catch
is our build currently explodes if we do it, so a couple scripts needed
adjustment. It just avoids doing the UI build work when we aren't actually
looking to do it.
1. Check out the ticket itself.
1. In practice, I don't know that anyone actually runs the script without
already having relevant builds (after all, messing with deps file is pretty
much the last thing anybody does). We could split the difference and add a flag
to run the build to the script and kick out a warning if it's not done or
something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
