justinleet commented on a change in pull request #1568: METRON-2324:
verify_licenses.sh and list_dependencies.sh don't properly handle maven failures
URL: https://github.com/apache/metron/pull/1568#discussion_r354474158
##########
File path: dev-utilities/build-utils/list_dependencies.sh
##########
@@ -16,4 +16,16 @@
# limitations under the License.
#
-{ mvn dependency:list || { echo "ERROR: Failed to run mvn dependency:list" ;
exit 1 ; } ; mvn dependency:list -PHDP-2.5.0.0 || { echo "ERROR: Failed to run
mvn dependency:list -PHDP-2.5.0.0" ; exit 1 ; } ; } | grep "^\[INFO\] " | awk
'{print $2}' | grep -v "org.apache" | grep -v "test" | grep -v "provided" |
grep -v "runtime" | grep -v ":system" | sort | uniq
+DEPS=$(mvn dependency:list)
+rc=$?
Review comment:
It's one of the main fixes, because of the incorrect failure handling
described in the ticket. It has to do with exiting during pipes not stopping
the chained call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
