[ 
https://issues.apache.org/jira/browse/METRON-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305801#comment-15305801
 ] 

ASF GitHub Bot commented on METRON-189:
---------------------------------------

Github user james-sirota commented on the pull request:

    https://github.com/apache/incubator-metron/pull/138#issuecomment-222347328
  
    I spot checked the validators and the validators work.  I checked IP, 
domain, url and date using YAF and Bro.  I did not test the negative case since 
the dead letter q does not yet exist.  One thing of note I see that you are 
using commons validator and in my previous experience this library has pretty 
significant performance issues validating IPs.  I think checking it with regex 
was 10 times faster or something around there.  Once we get to performance 
tuning this may be something to keep in mind.  Otherwise great job!  +1 


> Add the ability to do global validations on messages passing through the 
> parser.
> --------------------------------------------------------------------------------
>
>                 Key: METRON-189
>                 URL: https://issues.apache.org/jira/browse/METRON-189
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Casey Stella
>            Assignee: Casey Stella
>
> Allow the user to specify field level or message level validations to ensure 
> messages coming from the parser are valid.  For instance, allow the ability 
> ensure that a field is an IPv4 address.
> If a field is invalid, send to a separate stream from the parser bolt.  
> Follow-on work should be done to send this stream to the index for 
> after-the-fact inspection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to