[
https://issues.apache.org/jira/browse/METRON-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311368#comment-15311368
]
ASF GitHub Bot commented on METRON-189:
---------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/138#discussion_r65462013
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -165,8 +174,17 @@ public void execute(Tuple tuple) {
}
}
+ private boolean isGloballyValid(JSONObject input, List<FieldValidator>
validators) {
+ boolean ret = true;
+ for(FieldValidator validator : validators) {
+ ret &= validator.isValid(input,
getConfigurations().getGlobalConfig());
--- End diff --
Would it be more efficient to break on a failed validation?
> Add the ability to do global validations on messages passing through the
> parser.
> --------------------------------------------------------------------------------
>
> Key: METRON-189
> URL: https://issues.apache.org/jira/browse/METRON-189
> Project: Metron
> Issue Type: New Feature
> Reporter: Casey Stella
> Assignee: Casey Stella
>
> Allow the user to specify field level or message level validations to ensure
> messages coming from the parser are valid. For instance, allow the ability
> ensure that a field is an IPv4 address.
> If a field is invalid, send to a separate stream from the parser bolt.
> Follow-on work should be done to send this stream to the index for
> after-the-fact inspection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)