[ 
https://issues.apache.org/jira/browse/METRON-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728665#comment-15728665
 ] 

ASF GitHub Bot commented on METRON-612:
---------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/incubator-metron/pull/389
  
    @dlyle65535 Yeah, I spun up quick dev and made sure things passed through 
on topologies through to ES. I didn't extensively test other components in 
quick-dev, given that most of these changes are actually just built-in IDE 
refactorings (even the catches and combining Exceptions from `getConstructor()` 
get handled by IntelliJ) and non-behavior changes (`@Overrides`).
    
    Given that maas and the profiler have very minor changes and are covered by 
integration tests, I didn't spin those up.  If we do want those spun up (or 
anything else), I can definitely do so.


> Clean up Error Prone generated warnings
> ---------------------------------------
>
>                 Key: METRON-612
>                 URL: https://issues.apache.org/jira/browse/METRON-612
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Minor
>
> As a result of METRON-593, we have a new set of warnings in our code that 
> should be addressed.  593 already addressed errors (as those would break the 
> build otherwise).
> These can be seen in the mvn compile output of the various modules.  It 
> includes things like missing Override annotations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to