[
https://issues.apache.org/jira/browse/METRON-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728784#comment-15728784
]
ASF GitHub Bot commented on METRON-612:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/389
@dlyle65535 Any preference on making any of the warnings into compile-time
errors? Specifically:
SynchronizeOnNonFinalField, BoxedPrimitiveConstructor, ClassCanBeStatic,
and ClassNewInstance
Notably, BoxedPrimitiveConstructor and ClassNewInstance both address issues
with using code that'll be deprecated in Java 9 anyway.
They can be done with a pretty simple POM edit, e.g.
<compilerArgs>
<arg>-Xlint:unchecked</arg>
<arg>-Xep:SynchronizeOnNonFinalField:ERROR</arg>
<arg>-Xep:BoxedPrimitiveConstructor:ERROR</arg>
<...>
</compilerArgs>
> Clean up Error Prone generated warnings
> ---------------------------------------
>
> Key: METRON-612
> URL: https://issues.apache.org/jira/browse/METRON-612
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Minor
>
> As a result of METRON-593, we have a new set of warnings in our code that
> should be addressed. 593 already addressed errors (as those would break the
> build otherwise).
> These can be seen in the mvn compile output of the various modules. It
> includes things like missing Override annotations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
