[
https://issues.apache.org/jira/browse/METRON-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735084#comment-15735084
]
ASF GitHub Bot commented on METRON-587:
---------------------------------------
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/374
Resolved the issue: The enrichment test is different in that it expect
both errors and messages of the same amount. The code was not handling the
circumstance where the errors arrived before the messages from kafka correctly.
> Integration tests should use common processor implementations where possible
> ----------------------------------------------------------------------------
>
> Key: METRON-587
> URL: https://issues.apache.org/jira/browse/METRON-587
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> We have 7 or so integration tests that implement the Processor interface.
> Much of the code in these implementations is the same. It would be better
> for the system if we had some common implementations of the Processor
> interface.
> - This would make it easier to write correct tests
> - This would reduce errors from copy/paste test generation
> - This would clean up the codebase and make it easier to understand
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
