[
https://issues.apache.org/jira/browse/METRON-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753000#comment-15753000
]
ASF GitHub Bot commented on METRON-587:
---------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/374#discussion_r92731270
--- Diff:
metron-platform/metron-enrichment/src/test/java/org/apache/metron/enrichment/integration/EnrichmentIntegrationTest.java
---
@@ -153,9 +168,17 @@ public void test() throws Exception {
fluxComponent.submitTopology();
kafkaComponent.writeMessages(Constants.ENRICHMENT_TOPIC,
inputMessages);
- ProcessorResult<List<Map<String, Object>>> result =
runner.process(getProcessor(inputMessages));
+ ProcessorResult<List<Map<String, Object>>> result =
runner.process(getProcessor());
// We expect failures, so we don't care if result returned failure
or not
List<Map<String, Object>> docs = result.getResult();
+ // OTTO>>>>>>>>>>>>>>>>>>>
--- End diff --
*might* not want the OTTO there, unless you want to be immortalized in
Metron code @ottobackwards ;) Lord knows the `StellarTest` has enough
mentions of my name, though, so I can't talk.
> Integration tests should use common processor implementations where possible
> ----------------------------------------------------------------------------
>
> Key: METRON-587
> URL: https://issues.apache.org/jira/browse/METRON-587
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> We have 7 or so integration tests that implement the Processor interface.
> Much of the code in these implementations is the same. It would be better
> for the system if we had some common implementations of the Processor
> interface.
> - This would make it easier to write correct tests
> - This would reduce errors from copy/paste test generation
> - This would clean up the codebase and make it easier to understand
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
