[
https://issues.apache.org/jira/browse/METRON-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770780#comment-15770780
]
ASF GitHub Bot commented on METRON-639:
---------------------------------------
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/402
@justinleet It's a good point you make and a very good catch. I am using
URIs specifically because if Java doesn't know about the protocol scheme, then
it bails. I'd hate for someone to ingest URLs of a custom scheme or a scheme
that is more esoteric than is supported by Java and have it bail.
That being said, after further investigation, URLs are not a subset of
URIs. As per
http://stackoverflow.com/questions/176264/what-is-the-difference-between-a-uri-a-url-and-a-urn/1984225#1984225:
> Not "all URLs are URIs". It depends on the interpretation of the RFC. For
example in Java the URI parser does not like [ or ] and that's because the spec
says "should not" and not "shall not".
I'll have to consider whether or not I want to revert back to URL's and
make a comment for further study/analysis or whether I want to try something
else here.
> The Network Stellar functions need to have better unit testing
> --------------------------------------------------------------
>
> Key: METRON-639
> URL: https://issues.apache.org/jira/browse/METRON-639
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> We have very little unit test coverage around the Networking functions in
> Stellar at the edge level. When diving a bit deeper on real data, I found a
> number of bugs around:
> * Domains with TLDs that are not part of the proper set of TLDs
> * URIs with schemes that Java doesn't know about.
> * IN_SUBNET takes multiple CIDRs, but only evaluates the first one.
> Generally calling validate on these methods can be unsafe because they do not
> handle null arguments correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
