[
https://issues.apache.org/jira/browse/METRON-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770863#comment-15770863
]
ASF GitHub Bot commented on METRON-639:
---------------------------------------
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/402
@justinleet I thought about it a bit more and decided that a sensible
approach would be to validate the URL via commons validator and THEN parse
using java.net.URI. This would mean that URIs which are not URL's would not
parse, but URLs would parse regardless of scheme.
What other test cases would you suggest (preferably with example URLs, if
you don't mind)?
> The Network Stellar functions need to have better unit testing
> --------------------------------------------------------------
>
> Key: METRON-639
> URL: https://issues.apache.org/jira/browse/METRON-639
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> We have very little unit test coverage around the Networking functions in
> Stellar at the edge level. When diving a bit deeper on real data, I found a
> number of bugs around:
> * Domains with TLDs that are not part of the proper set of TLDs
> * URIs with schemes that Java doesn't know about.
> * IN_SUBNET takes multiple CIDRs, but only evaluates the first one.
> Generally calling validate on these methods can be unsafe because they do not
> handle null arguments correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
