[
https://issues.apache.org/jira/browse/METRON-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818721#comment-15818721
]
ASF GitHub Bot commented on METRON-532:
---------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/414#discussion_r95610064
--- Diff:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java
---
@@ -132,36 +157,26 @@
private static final Logger LOG =
LoggerFactory.getLogger(GetProfile.class);
- /**
- * A client that can retrieve profile values.
- */
+ // Cached client that can retrieve profile values.
--- End diff --
Just curious, why change the comment style? When should I use
javadoc-style comments versus traditional `//`?
> Define Profile Period When Calling PROFILE_GET
> ----------------------------------------------
>
> Key: METRON-532
> URL: https://issues.apache.org/jira/browse/METRON-532
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Matt Foley
> Fix For: 0.3.0
>
>
> The Profiler Client currently offers the PROFILE_GET Stellar function to
> access profile data. The work done for METRON-529 allowed the user to
> customize the profile period using Metron global properties.
> A user may need to access historical profiles with different durations and
> would want to specify the period as part of the call to the Profiler Client,
> rather than in the Metron global properties.
> This would be especially necessary should METRON-530 be completed allowing
> different profiles to use different period durations simultaneously.
> There is some discussion of this attached to METRON-529.
> See also discussion in METRON-594 "Replay Telemetry Data through Profiler".
> Note: At suggestion of [~cestella], scope of this work item was expanded to
> include checking for config changes at run time, in the PROFILE_GET Stellar
> function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
