[
https://issues.apache.org/jira/browse/METRON-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818843#comment-15818843
]
ASF GitHub Bot commented on METRON-532:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/414
@nickwallen and @cestella, thanks for the comments. Regarding multiple
optional args, I followed the rule that if the second optional arg is provided,
then the first "optional" arg isn't optional; or more generally, if a later
optional arg is provided, all preceding optional args must also be provided,
even if with trivial values. No tricky polymorphisms with object types, just a
simple argument count. I think that's the best we can do without named
arguments.
BTW, @cestella , my previous PR-345 did use object type checking to allow
either or both to be truly optional, but it felt very hacky, was obviously not
generalizable, and I was happy to change to this.
Hopefully I made this clear for users in both the comments and documents.
Let me know if you feel more needs to be said. Thanks.
> Define Profile Period When Calling PROFILE_GET
> ----------------------------------------------
>
> Key: METRON-532
> URL: https://issues.apache.org/jira/browse/METRON-532
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Matt Foley
> Fix For: 0.3.0
>
>
> The Profiler Client currently offers the PROFILE_GET Stellar function to
> access profile data. The work done for METRON-529 allowed the user to
> customize the profile period using Metron global properties.
> A user may need to access historical profiles with different durations and
> would want to specify the period as part of the call to the Profiler Client,
> rather than in the Metron global properties.
> This would be especially necessary should METRON-530 be completed allowing
> different profiles to use different period durations simultaneously.
> There is some discussion of this attached to METRON-529.
> See also discussion in METRON-594 "Replay Telemetry Data through Profiler".
> Note: At suggestion of [~cestella], scope of this work item was expanded to
> include checking for config changes at run time, in the PROFILE_GET Stellar
> function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
