[ 
https://issues.apache.org/jira/browse/METRON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832059#comment-15832059
 ] 

ASF GitHub Bot commented on METRON-503:
---------------------------------------

Github user jjmeyer0 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/316#discussion_r97105827
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/KafkaService.java
 ---
    @@ -0,0 +1,112 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.rest.service;
    +
    +import kafka.admin.AdminUtils;
    +import kafka.admin.RackAwareMode;
    +import kafka.utils.ZkUtils;
    +import org.apache.kafka.clients.consumer.ConsumerRecord;
    +import org.apache.kafka.clients.consumer.ConsumerRecords;
    +import org.apache.kafka.clients.consumer.KafkaConsumer;
    +import org.apache.kafka.common.PartitionInfo;
    +import org.apache.kafka.common.TopicPartition;
    +import org.apache.metron.rest.model.KafkaTopic;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.stereotype.Service;
    +
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Set;
    +import java.util.stream.Collectors;
    +
    +@Service
    +public class KafkaService {
    +
    +    @Autowired
    +    private ZkUtils zkUtils;
    +
    +    @Autowired
    +    private KafkaConsumer<String, String> kafkaConsumer;
    +
    +    private String offsetTopic = "__consumer_offsets";
    +
    +    public KafkaTopic createTopic(KafkaTopic topic) {
    +        if (!listTopics().contains(topic.getName())) {
    --- End diff --
    
    It looks like this can throw a AdminOperationException. Is there a way we 
can map these to our RestException? We may be able to do this through another 
`ResponseEntityExceptionHandler`


> Metron REST API
> ---------------
>
>                 Key: METRON-503
>                 URL: https://issues.apache.org/jira/browse/METRON-503
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>         Attachments: Metron REST API.docx
>
>
> As discussed on the dev list ([DISCUSS] Metron REST API Requirements), this 
> Jira includes adding a REST API to Metron.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to