[
https://issues.apache.org/jira/browse/METRON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832091#comment-15832091
]
ASF GitHub Bot commented on METRON-503:
---------------------------------------
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
I've tested a few controllers (global config, grok controller, and kafka
controller). Everything seems to be working pretty well. I will continue to
test more, but since this is a large PR I wanted to do smaller chunks at a time.
I think we should start thinking about is how we are going to architect the
service layer. I'd like to discuss two things that I think will help us improve
the maintainability of this.
*Each service should implement an interface.**
**We should discuss how to better break up services.**
I think services should be conceptually simple. Mostly interact with a
specific system. If we start getting into more complicated situations where
multiple services are needed these should be in a separate area. I consider
situations like these to be more of a service facade. A current example of this
is with the `StormService`. I think the interactions with the storm API should
be in its own service. Then a facade would be used with the storm service and
other necessary services to give a simpler view into storm based on our
context. Does this make sense?
Personally I think number 1 should be done apart of this PR and number 2
should probably turn into a wider discussion. What do you all think? If others
agree, I'd be glad to write up a Jira to discuss number 2.
> Metron REST API
> ---------------
>
> Key: METRON-503
> URL: https://issues.apache.org/jira/browse/METRON-503
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Attachments: Metron REST API.docx
>
>
> As discussed on the dev list ([DISCUSS] Metron REST API Requirements), this
> Jira includes adding a REST API to Metron.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
