[
https://issues.apache.org/jira/browse/METRON-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834667#comment-15834667
]
ASF GitHub Bot commented on METRON-283:
---------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/421#discussion_r97327302
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
---
@@ -161,6 +167,7 @@ protected void initializeStellar() {
stellarContext = new Context.Builder()
.with(Context.Capabilities.ZOOKEEPER_CLIENT, ()
-> client)
.with(Context.Capabilities.GLOBAL_CONFIG, () ->
getConfigurations().getGlobalConfig())
+ .with(Context.Capabilities.GEO_IP, () ->
GeoLiteDatabase.INSTANCE)
--- End diff --
Since the INSTANCE is static, is there a reason to not just refer to it
directly in the Stellar function rather than adding a capability? I always
envisioned capabilities to be for configs which were changing at runtime.
> Migrate Geo Enrichment outside of MySQL
> ---------------------------------------
>
> Key: METRON-283
> URL: https://issues.apache.org/jira/browse/METRON-283
> Project: Metron
> Issue Type: Improvement
> Reporter: James Sirota
> Assignee: Justin Leet
> Priority: Minor
>
> We need to migrate our enrichment SQL store from MySQL to Phoenix or some
> other SQL on Hbase library. Or alternatively come up with a way to do this
> without using SQL. This way we don't have a dependency on MySQL and there is
> one less thing that we need to install on our platform
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
