[ 
https://issues.apache.org/jira/browse/METRON-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837679#comment-15837679
 ] 

ASF GitHub Bot commented on METRON-283:
---------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/421#discussion_r97770743
  
    --- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
 ---
    @@ -161,6 +167,7 @@ protected void initializeStellar() {
         stellarContext = new Context.Builder()
                              .with(Context.Capabilities.ZOOKEEPER_CLIENT, () 
-> client)
                              .with(Context.Capabilities.GLOBAL_CONFIG, () -> 
getConfigurations().getGlobalConfig())
    +                         .with(Context.Capabilities.GEO_IP, () -> 
GeoLiteDatabase.INSTANCE)
    --- End diff --
    
    @cestella Capability was left over from earlier testing.  Everything 
referred to the static instance anyway for precisely that reason.  Dropped it 
entirely and removed from the enum.
    
    @dlyle65535 There's not a geo specific bolt, it's an instance of 
GenericEnrichment. To the best of my knowledge (and correct me if I'm wrong), 
you can't grab global configs in the adapters.  This specific one gets dropped, 
but the prepare() method references the static INSTANCE Casey refers to.  Is 
there somewhere that could live?
    



> Migrate Geo Enrichment outside of MySQL
> ---------------------------------------
>
>                 Key: METRON-283
>                 URL: https://issues.apache.org/jira/browse/METRON-283
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: James Sirota
>            Assignee: Justin Leet
>            Priority: Minor
>
> We need to migrate our enrichment SQL store from MySQL to Phoenix or some 
> other SQL on Hbase library.  Or alternatively come up with a way to do this 
> without using SQL.  This way we don't have a dependency on MySQL and there is 
> one less thing that we need to install on our platform 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to