[
https://issues.apache.org/jira/browse/METRON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837016#comment-15837016
]
ASF GitHub Bot commented on METRON-503:
---------------------------------------
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr this is looking good. I like how you broke out some of the
services and started a constants class. There were two very minor things that I
noticed.
1. `@Override` should be used wherever possible on all service class method
that implement an interface.
2. I don't believe `@Service` is needed on the interfaces.
I continued to test some more endpoints and things are continuing to look
good. I still want to test out some more endpoints.
> Metron REST API
> ---------------
>
> Key: METRON-503
> URL: https://issues.apache.org/jira/browse/METRON-503
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Attachments: Metron REST API.docx
>
>
> As discussed on the dev list ([DISCUSS] Metron REST API Requirements), this
> Jira includes adding a REST API to Metron.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
