[
https://issues.apache.org/jira/browse/METRON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843128#comment-15843128
]
ASF GitHub Bot commented on METRON-503:
---------------------------------------
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr looks like you will need to resolve some conflicts.
Also, I looked at this some more. It looks like there aren't many unit
tests for the service layer. It seems like it's indirectly tested through the
controllers, but I think there is still some benefit to having unit tests
against the services themselves. Before I made this comment I wanted to work
through an example, and I created a test for `KafkaServiceImpl`. If you want to
see that I'd be more than glad to share. Otherwise, I was just thinking we
could inject all dependencies as mocks using PowerMock or Mockito. Then
continue to test normally. This takes things like spring and any external
system out of the picture and focuses just on the implementation of the
services.
> Metron REST API
> ---------------
>
> Key: METRON-503
> URL: https://issues.apache.org/jira/browse/METRON-503
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Attachments: Metron REST API.docx
>
>
> As discussed on the dev list ([DISCUSS] Metron REST API Requirements), this
> Jira includes adding a REST API to Metron.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
