[
https://issues.apache.org/jira/browse/METRON-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838042#comment-15838042
]
ASF GitHub Bot commented on METRON-283:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/421#discussion_r97818189
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/stellar/GeoEnrichmentFunctions.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.enrichment.stellar;
+
+import org.apache.log4j.Logger;
+import org.apache.metron.common.dsl.Context;
+import org.apache.metron.common.dsl.ParseException;
+import org.apache.metron.common.dsl.Stellar;
+import org.apache.metron.common.dsl.StellarFunction;
+import org.apache.metron.enrichment.adapters.geo.GeoLiteDatabase;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+public class GeoEnrichmentFunctions {
+ private static final Logger LOG =
Logger.getLogger(GeoEnrichmentFunctions.class);
+
+ @Stellar(name="GET"
+ ,namespace="GEO"
+ ,description="Look up an IPV4 address and returns geographic
information about it"
+ ,params = {
+ "ip - The IPV4 address to lookup" +
+ "fields - Optional list of GeoIP fields to grab.
Options are locID, country, city, postalCode, dmaCode, latitude, longitude,
location_point"
+ }
+ ,returns = "If a Single field is requested a string of the
field, If multiple fields a map of string of the fields, and null otherwise"
+ )
+ public static class GeoGet implements StellarFunction {
+ boolean initialized = false;
+
+ @Override
+ public Object apply(List<Object> args, Context context) throws
ParseException {
+ if(!initialized) {
+ return null;
+ }
+ if(args.size() > 2) {
+ return null;
--- End diff --
Is there a well defined expectation for what happens in cases like this? I
don't think I've seen anything, and on reflection I'm pretty sure I just based
that off what other functions did.
@cestella Can you shed some light on what perceptions/expectations exist
for this case? Or shame my reading comprehension by pointing me to where we
have them documented, if we do?
> Migrate Geo Enrichment outside of MySQL
> ---------------------------------------
>
> Key: METRON-283
> URL: https://issues.apache.org/jira/browse/METRON-283
> Project: Metron
> Issue Type: Improvement
> Reporter: James Sirota
> Assignee: Justin Leet
> Priority: Minor
>
> We need to migrate our enrichment SQL store from MySQL to Phoenix or some
> other SQL on Hbase library. Or alternatively come up with a way to do this
> without using SQL. This way we don't have a dependency on MySQL and there is
> one less thing that we need to install on our platform
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
