[
https://issues.apache.org/jira/browse/METRON-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838105#comment-15838105
]
ASF GitHub Bot commented on METRON-283:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/421#discussion_r97824391
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
---
@@ -149,9 +154,10 @@ public JSONObject load(CacheKey key) throws Exception {
cache = CacheBuilder.newBuilder().maximumSize(maxCacheSize)
.expireAfterWrite(maxTimeRetain, TimeUnit.MINUTES)
.build(loader);
+
GeoLiteDatabase.INSTANCE.update((String)getConfigurations().getGlobalConfig().get(GeoLiteDatabase.GEO_HDFS_FILE));
boolean success = adapter.initializeAdapter();
--- End diff --
You're right that if we adjust the enrichment adapter to accept
configuration values, this can be pushed to the GeoAdapter, where I agree it
makes more sense.
Are there concerns over changing the interface method directly, or would we
prefer to give `EnrichmentAdapter` a `initializeAdapter(Map<String, Object>
config)` with default impl that calls `initializeAdapter()` with no args? The
second option makes it a bit ugly that `GeoAdapter` still has the original
`initializeAdapter()`, but has the benefit of keeping the interface backwards
compatible to anybody with custom adapters (Is this a thing that people have?).
And you are correct that there is an issue with initializing a missing DB
(Great catch!). If we make this change, I believe the only time you'd have an
issue is if you set up a geo enrichment and didn't actually set up the DB.
Which is an entirely reasonable issue to have an error with.
@dlyle65535 Would this address your concerns about having the init in the
GenericEnrichmentBolt in a satisfactory manner?
> Migrate Geo Enrichment outside of MySQL
> ---------------------------------------
>
> Key: METRON-283
> URL: https://issues.apache.org/jira/browse/METRON-283
> Project: Metron
> Issue Type: Improvement
> Reporter: James Sirota
> Assignee: Justin Leet
> Priority: Minor
>
> We need to migrate our enrichment SQL store from MySQL to Phoenix or some
> other SQL on Hbase library. Or alternatively come up with a way to do this
> without using SQL. This way we don't have a dependency on MySQL and there is
> one less thing that we need to install on our platform
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
