[
https://issues.apache.org/jira/browse/METRON-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852797#comment-15852797
]
ASF GitHub Bot commented on METRON-684:
---------------------------------------
GitHub user cestella reopened a pull request:
https://github.com/apache/incubator-metron/pull/435
METRON-684: Decouple Timestamp calculation from PROFILE_GET
Currently `PROFILE_GET` only supports a static lookback of a fixed
duration. As we have more complicated, potentially sparse, lookbacks (e.g. the
same time slice every tuesday for a month), it would be nice to decouple the
construction of timestamps from `PROFILE_GET` into its own set of functions.
The decoupling plus the default timestamp function is provided here, which
is a fixed window starting from now. This is implemented as `PROFILE_FIXED`.
Test plan to follow.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/435.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #435
----
commit 6d6b0385a23fb2b8512e6cb85425425e73159be1
Author: cstella <[email protected]>
Date: 2017-02-02T17:17:57Z
METRON-684: Decouple Timestamp calculation from PROFILE_GET
commit 365444a84c4d0142262d01a739aea6df525c2228
Author: cstella <[email protected]>
Date: 2017-02-02T17:22:00Z
Licensing and a stupid search/replace mistake.
commit 5d6bac6f5e15ab8056cf86cbedcf3f82b82e3ca1
Author: cstella <[email protected]>
Date: 2017-02-02T18:00:17Z
Fixed comments and licenses.
commit 1a80d32ce2bd59746b0b0b453ce867a9fea4f8f8
Author: cstella <[email protected]>
Date: 2017-02-02T20:34:19Z
We want to transform the timestamp, not the period
commit e98f80cf472bbc62bce3b8cb8dae6068bee6eb9f
Author: cstella <[email protected]>
Date: 2017-02-02T20:53:22Z
Whoops, mistook profile measurement periods for timestamps..they are not.
commit 6ed69fb17b66d97cb20e6da2eeefa9574b5145d8
Author: cstella <[email protected]>
Date: 2017-02-02T21:03:46Z
Updating docs and variable naming to better reflect that we are interacting
with profile periods, not timestamps.
commit c49eb2cee62c5044ca2e88f44375f5e1c151a7eb
Author: cstella <[email protected]>
Date: 2017-02-02T21:05:17Z
renamed visitor
commit d2008fa8c78ff83c6532443ffdc57a46332ebfb1
Author: cstella <[email protected]>
Date: 2017-02-03T18:15:43Z
reacting to nick's comments
commit 4869f563f5293a3c57d5de2671f3fbb1e0908f6a
Author: cstella <[email protected]>
Date: 2017-02-03T18:18:34Z
Updated docs.
----
> Decouple Timestamp calculation from PROFILE_GET
> -----------------------------------------------
>
> Key: METRON-684
> URL: https://issues.apache.org/jira/browse/METRON-684
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Assignee: Casey Stella
>
> Currently PROFILE_GET only supports a static lookback of a fixed duration.
> As we have more complicated, potentially sparse, lookbacks (e.g. the same
> time slice every tuesday for a month), it would be nice to decouple the
> construction of timestamps from PROFILE_GET into its own set of functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
