[
https://issues.apache.org/jira/browse/METRON-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851702#comment-15851702
]
ASF GitHub Bot commented on METRON-684:
---------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/435#discussion_r99375854
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/ProfilePeriod.java
---
@@ -51,7 +61,7 @@ public ProfilePeriod(long epochMillis, long duration,
TimeUnit units) {
throw new IllegalArgumentException(format(
"period duration must be greater than 0; got '%d %s'",
duration, units));
}
-
+ this.timestamp = epochMillis;
--- End diff --
That's good feedback, agreed.
> Decouple Timestamp calculation from PROFILE_GET
> -----------------------------------------------
>
> Key: METRON-684
> URL: https://issues.apache.org/jira/browse/METRON-684
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Assignee: Casey Stella
>
> Currently PROFILE_GET only supports a static lookback of a fixed duration.
> As we have more complicated, potentially sparse, lookbacks (e.g. the same
> time slice every tuesday for a month), it would be nice to decouple the
> construction of timestamps from PROFILE_GET into its own set of functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
