[
https://issues.apache.org/jira/browse/METRON-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872133#comment-15872133
]
ASF GitHub Bot commented on METRON-724:
---------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/incubator-metron/pull/457
METRON-724 add [IN] to the documented keywords that require escaping
The keyword 'in' must be escaped to be used in Stellar, but is not
documented as such.
This PR adds in the documentation and a unit test.
Verify:
- by running the tests
- by using the Stellar Console to evaluate an expression
- by building and viewing the documentation ( see below ) and the readme.md
in github
----------------------------
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
guildlines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check
the following:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ n/a] Have you included steps to reproduce the behavior or problem that
is being changed or addressed?
- [x ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [n/a ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [n/a ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
site-book/target/site/index.html.
```
cd site-book
bin/generate-md.sh
mvn site:site
```
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/incubator-metron METRON-724
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #457
----
commit b90987bbeca346301a18aea2a7913a072fde4a3a
Author: Otto Fowler <[email protected]>
Date: 2017-02-17T17:06:58Z
METRON-724 add [IN] to the documented keywords that require escaping
add in unit test
----
> Account for `in` grammar in Stellar Documentation and Unit Tests
> ----------------------------------------------------------------
>
> Key: METRON-724
> URL: https://issues.apache.org/jira/browse/METRON-724
> Project: Metron
> Issue Type: Bug
> Reporter: Jon Zeolla
> Assignee: Otto Fowler
>
> Per conversation in the METRON-708 PR
> (https://github.com/apache/incubator-metron/pull/447) we should add the `in`
> operator to the “must be single quoted” table documentation under
> metron-platform/metron-common/ and ensure that the appropriate unit tests
> exist.
> Assigning to Otto via the below chat:
> [15:23:17] <ottO_> honestly - just log the jira and assign it to me
> [15:23:33] <ottO_> i don't mind you owing me one
> [15:23:36] <ottO_> ;)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
