[ 
https://issues.apache.org/jira/browse/METRON-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872442#comment-15872442
 ] 

ASF GitHub Bot commented on METRON-724:
---------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/457#discussion_r101838232
  
    --- Diff: 
metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java
 ---
    @@ -288,6 +289,26 @@ public void testIfThenElse() {
       }
     
       @Test
    +  public void testInNotIN(){
    +    HashMap variables = new HashMap<>();
    +    boolean thrown = false;
    +    try{
    +      run("in in ['','in']" ,variables );
    --- End diff --
    
    We could probably `Assert.assertFalse((boolean)run("in in ['', 'in']", 
variables))` and ensure expected behavior.  Similarly for the other case.


> Account for `in` grammar in Stellar Documentation and Unit Tests
> ----------------------------------------------------------------
>
>                 Key: METRON-724
>                 URL: https://issues.apache.org/jira/browse/METRON-724
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Jon Zeolla
>            Assignee: Otto Fowler
>
> Per conversation in the METRON-708 PR 
> (https://github.com/apache/incubator-metron/pull/447) we should add the `in` 
> operator to the “must be single quoted” table documentation under 
> metron-platform/metron-common/ and ensure that the appropriate unit tests 
> exist.  
> Assigning to Otto via the below chat:
> [15:23:17]  <ottO_>   honestly - just log the jira and assign it to me
> [15:23:33]  <ottO_>   i don't mind you owing me one
> [15:23:36]  <ottO_>   ;)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to