[
https://issues.apache.org/jira/browse/METRON-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888867#comment-15888867
]
ASF GitHub Bot commented on METRON-744:
---------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/468#discussion_r103550096
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/ClassloaderUtil.java
---
@@ -0,0 +1,146 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.common.utils;
+
+import org.apache.accumulo.start.classloader.vfs.UniqueFileReplicator;
+import org.apache.commons.logging.Log;
+import org.apache.commons.vfs2.*;
+import org.apache.commons.vfs2.cache.SoftRefFilesCache;
+import org.apache.commons.vfs2.impl.DefaultFileSystemManager;
+import org.apache.commons.vfs2.impl.FileContentInfoFilenameFactory;
+import org.apache.commons.vfs2.impl.VFSClassLoader;
+import org.apache.commons.vfs2.provider.FileReplicator;
+import org.apache.commons.vfs2.provider.UriParser;
+import org.apache.commons.vfs2.provider.VfsComponent;
+import org.apache.commons.vfs2.provider.VfsComponentContext;
+import org.apache.commons.vfs2.provider.hdfs.HdfsFileProvider;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.*;
+
+public class ClassloaderUtil {
--- End diff --
Javadoc would be awesome. I don't know how I would use these functions.
Seems like you put them here because you think there are opportunities for
reuse.
Also, whitespace and formatting is a little screwy in this file.
> Allow Stellar functions to be loaded from HDFS
> ----------------------------------------------
>
> Key: METRON-744
> URL: https://issues.apache.org/jira/browse/METRON-744
> Project: Metron
> Issue Type: New Feature
> Reporter: Casey Stella
>
> The benefit of Stellar is that adding new functionality is as simple as
> providing a Jar. This enables people who want to integrate with Metron to
> easy add enrichments or other functionality. The snag currently with this is
> that we provide a single jar, so all stellar functions that we have available
> must be dependencies of the main jar that drives the topology plus what local
> directories we can configure via the storm configs. This makes the process
> of adding 3rd party jars not as easy as it could be.
> Adjust the the following to additionally load classes from a location in HDFS
> /apps/metron/stellar using something like accumulo (
> https://accumulo.apache.org/blog/2014/05/03/accumulo-classloader.html)
> * Profiler topology
> * Parser topology
> * Enrichment topology
> * Enrichment Flat file loader
> * Enrichment MR loader
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
