[ 
https://issues.apache.org/jira/browse/METRON-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888870#comment-15888870
 ] 

ASF GitHub Bot commented on METRON-744:
---------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/468#discussion_r103549252
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/resolver/ClasspathFunctionResolver.java
 ---
    @@ -65,24 +72,48 @@
      *
      */
     public class ClasspathFunctionResolver extends BaseFunctionResolver {
    -
    -  /**
    -   * The key for a global property that defines one or more regular 
expressions
    -   * that specify what should be included when searching for Stellar 
functions.
    -   */
    -  public static final String STELLAR_SEARCH_INCLUDES_KEY = 
"stellar.function.resolver.includes";
    -
    -  /**
    +  public enum Config {
    +    STELLAR_VFS_PATHS("stellar.function.paths", ""),
    +    /**
    +     * The key for a global property that defines one or more regular 
expressions
    +     * that specify what should be included when searching for Stellar 
functions.
    +     */
    +    STELLAR_SEARCH_INCLUDES_KEY("stellar.function.resolver.includes", ""),
    --- End diff --
    
    Do we still need this with the index-based approach?  We had this here 
before to minimize how many packages we had to search because it was so time 
consuming.  What purpose does it serve now?


> Allow Stellar functions to be loaded from HDFS
> ----------------------------------------------
>
>                 Key: METRON-744
>                 URL: https://issues.apache.org/jira/browse/METRON-744
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Casey Stella
>
> The benefit of Stellar is that adding new functionality is as simple as 
> providing a Jar.  This enables people who want to integrate with Metron to 
> easy add enrichments or other functionality.  The snag currently with this is 
> that we provide a single jar, so all stellar functions that we have available 
> must be dependencies of the main jar that drives the topology plus what local 
> directories we can configure via the storm configs.  This makes the process 
> of adding 3rd party jars not as easy as it could be.
> Adjust the the following to additionally load classes from a location in HDFS 
> /apps/metron/stellar using something like accumulo ( 
> https://accumulo.apache.org/blog/2014/05/03/accumulo-classloader.html)
> * Profiler topology
> * Parser topology
> * Enrichment topology
> * Enrichment Flat file loader
> * Enrichment MR loader



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to