[
https://issues.apache.org/jira/browse/METRON-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925376#comment-15925376
]
ASF GitHub Bot commented on METRON-764:
---------------------------------------
GitHub user mattf-horton opened a pull request:
https://github.com/apache/incubator-metron/pull/476
METRON-764 DST bug in metron-profiler-client Unit Tests
This is a Unit Test bug. Please see
https://issues.apache.org/jira/browse/METRON-764 for detailed description and
how to reproduce the problem.
I only changed a Unit Test file and a docs file, therefore I only tested
Unit Tests, which pass as shown by Travis. I also re-ran the reproduction
manually and showed it no longer happens with the fix.
=================
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [NA] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [NA] Have you written or updated unit tests and or integration tests to
verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [NA] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/incubator-metron METRON-764
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #476
----
commit e3b90ab9b5f96287076e1c2791fb4324505c28d6
Author: mattf-horton <[email protected]>
Date: 2017-03-14T23:25:33Z
METRON-764 DST bug in metron-profiler-client Unit Tests
----
> DST bug in metron-profiler-client Unit Tests
> --------------------------------------------
>
> Key: METRON-764
> URL: https://issues.apache.org/jira/browse/METRON-764
> Project: Metron
> Issue Type: Bug
> Reporter: Matt Foley
> Priority: Critical
>
> There is a Daylight Savings Time bug in the Unit Tests for
> metron-profiler-client. Here's how to repro:
> * On a Mac, during daytime, clone Metron and build master branch, including
> unit tests to confirm they work okay:
> ** mvn clean install
> * Now go into System Preferences, select "Date & Time", select left-most tab
> (also labeled "Date & Time"), and click the lock icon in the lower left to
> unlock the time settings.
> * Deselect the "set automatically" checkbox, then set the time and date to
> approximately 12:30AM on 3/14/2017, your local timezone.
> * Click save and lock.
> * Now run the unit tests just for metron-profiler-client:
> ** mvn install -rf :metron-profiler-client
> * They fail with:
> {code}
> Failed tests:
> WindowProcessorTest.testRepeatWithWeekdayExclusion:212 expected:<2> but
> was:<1>
> WindowProcessorTest.testRepeatWithWeekendExclusion:175 expected:<5> but
> was:<6>
> Tests run: 41, Failures: 2, Errors: 0, Skipped: 0
> {code}
> * Reverse the clock settings to get back to actual time with automatic
> settings.
> * Run "mvn install -rf :metron-profiler-client" again and it passes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
