[
https://issues.apache.org/jira/browse/METRON-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926129#comment-15926129
]
ASF GitHub Bot commented on METRON-764:
---------------------------------------
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/476
+1, great catch @mattf-horton !
> DST bug in metron-profiler-client Unit Tests
> --------------------------------------------
>
> Key: METRON-764
> URL: https://issues.apache.org/jira/browse/METRON-764
> Project: Metron
> Issue Type: Bug
> Reporter: Matt Foley
> Priority: Critical
>
> There is a Daylight Savings Time bug in the Unit Tests for
> metron-profiler-client. Here's how to repro:
> * On a Mac, during daytime, clone Metron and build master branch, including
> unit tests to confirm they work okay:
> ** mvn clean install
> * Now go into System Preferences, select "Date & Time", select left-most tab
> (also labeled "Date & Time"), and click the lock icon in the lower left to
> unlock the time settings.
> * Deselect the "set automatically" checkbox, then set the time and date to
> approximately 12:15AM on 3/14/2017, your local timezone.
> * Click save and lock.
> * Now run the unit tests just for metron-profiler-client:
> ** mvn install -rf :metron-profiler-client
> * They fail with:
> {code}
> Failed tests:
> WindowProcessorTest.testRepeatWithWeekdayExclusion:212 expected:<2> but
> was:<1>
> WindowProcessorTest.testRepeatWithWeekendExclusion:175 expected:<5> but
> was:<6>
> Tests run: 41, Failures: 2, Errors: 0, Skipped: 0
> {code}
> * Reverse the clock settings to get back to actual time with automatic
> settings.
> * Run "mvn install -rf :metron-profiler-client" again and it passes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)