[ 
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391821#comment-16391821
 ] 

ASF GitHub Bot commented on MXNET-42:
-------------------------------------

cjolivier01 commented on a change in pull request #9995: [WIP] CI docker 
revamp; Add Jetson, Raspberry and CentOS 7 build 
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173268948
 
 

 ##########
 File path: python/mxnet/libinfo.py
 ##########
 @@ -29,6 +30,17 @@ def find_lib_path():
     lib_path : list(string)
         List of all found path to the libraries.
     """
+    lib_from_env = os.environ.get('MXNET_LIBRARY_PATH')
+    if lib_from_env:
 
 Review comment:
   Does this also check for an empty string?  Some OS's, at least in C, will 
return a valid pointer from getenv() for an empty, yet defined, string
   ie
   export MXNET_LIBRARY_PATH=
   will return "" on some OS's, even though the intent is clearly to not be 
defined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make CI failures locally reproducible
> -------------------------------------
>
>                 Key: MXNET-42
>                 URL: https://issues.apache.org/jira/browse/MXNET-42
>             Project: Apache MXNet
>          Issue Type: Improvement
>            Reporter: Marco de Abreu
>            Assignee: Marco de Abreu
>            Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure 
> could be reproduced by executing a single command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org

Reply via email to