[
https://issues.apache.org/jira/browse/MXNET-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391923#comment-16391923
]
ASF GitHub Bot commented on MXNET-42:
-------------------------------------
cjolivier01 commented on a change in pull request #9995: [WIP] CI docker
revamp; Add Jetson, Raspberry and CentOS 7 build
[MXNET-42][MXNET-43][MXNET-44][MXNET-57]
URL: https://github.com/apache/incubator-mxnet/pull/9995#discussion_r173294029
##########
File path: CMakeLists.txt
##########
@@ -94,7 +95,13 @@ else(MSVC)
endif()
check_cxx_compiler_flag("-std=c++11" SUPPORT_CXX11)
check_cxx_compiler_flag("-std=c++0x" SUPPORT_CXX0X)
- check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
+ # For cross compilation, we can't rely on the compiler which accepts the
flag, but mshadow will
+ # add platform specific includes not available in other arches
+ if(USE_SSE STREQUAL "AUTO")
+ check_cxx_compiler_flag("-msse2" SUPPORT_MSSE2)
Review comment:
nit: the spacing before SUPPORT_MSSE2 becomes kind of pointless if the
check_cxx_compiler_flag(...) line isn;t still aligned with the rest of them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make CI failures locally reproducible
> -------------------------------------
>
> Key: MXNET-42
> URL: https://issues.apache.org/jira/browse/MXNET-42
> Project: Apache MXNet
> Issue Type: Improvement
> Reporter: Marco de Abreu
> Assignee: Marco de Abreu
> Priority: Major
>
> At the moment, it's hard to reproduce CI failures. Ideally, every failure
> could be reproduced by executing a single command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
