[
https://issues.apache.org/jira/browse/NIFI-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376005#comment-15376005
]
ASF GitHub Bot commented on NIFI-619:
-------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/575#discussion_r70727312
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MonitorActivity.java
---
@@ -168,17 +216,49 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final long now = System.currentTimeMillis();
final ComponentLog logger = getLogger();
+ final String monitoringScope =
context.getProperty(MONITORING_SCOPE).getValue();
+ final boolean copyAttributes =
context.getProperty(COPY_ATTRIBUTES).asBoolean();
+ final boolean isClusterScope =
SCOPE_CLUSTER.equals(monitoringScope);
final List<FlowFile> flowFiles = session.get(50);
+
+ boolean isInactive = false;
+ long updatedLatestSuccessTransfer = -1;
+ StateMap clusterState = null;
+ final boolean shouldThisNodeReport = !isClusterScope
--- End diff --
Good call. I'll move this condition to a function and call it just before
reporting attempts.
> update MonitorActivity processor to be cluster friendly
> -------------------------------------------------------
>
> Key: NIFI-619
> URL: https://issues.apache.org/jira/browse/NIFI-619
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Brandon DeVries
> Assignee: Koji Kawamura
> Priority: Minor
> Fix For: 1.0.0
>
>
> This processor should be able to be used to monitor activity across the
> cluster. In its current state, alerting is based on activity of a single
> node, not the entire cluster.
> For example, in a 2 node cluster, if system A is getting data from a given
> flow and system B is not, system B will alert for lack of activity even
> though the flow is functioning "normally".
> The ideal behavior would be fore an alert to be generated only if both
> systems did not see data in the specified time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
