[
https://issues.apache.org/jira/browse/NIFI-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377151#comment-15377151
]
ASF GitHub Bot commented on NIFI-619:
-------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/575#discussion_r70831015
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -1004,7 +1004,7 @@ public ProcessorNode createProcessor(final String
type, String id, final boolean
creationSuccessful = false;
}
- final ValidationContextFactory validationContextFactory = new
StandardValidationContextFactory(controllerServiceProvider);
+ final ValidationContextFactory validationContextFactory = new
StandardValidationContextFactory(controllerServiceProvider, this);
--- End diff --
I really don't like passing the FlowController itself. Why can't it just
pass the value? Or if it needs to be able to be updated, it could pass a shared
reference.
> update MonitorActivity processor to be cluster friendly
> -------------------------------------------------------
>
> Key: NIFI-619
> URL: https://issues.apache.org/jira/browse/NIFI-619
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Brandon DeVries
> Assignee: Koji Kawamura
> Priority: Minor
> Fix For: 1.0.0
>
>
> This processor should be able to be used to monitor activity across the
> cluster. In its current state, alerting is based on activity of a single
> node, not the entire cluster.
> For example, in a 2 node cluster, if system A is getting data from a given
> flow and system B is not, system B will alert for lack of activity even
> though the flow is functioning "normally".
> The ideal behavior would be fore an alert to be generated only if both
> systems did not see data in the specified time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
