[ 
https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381028#comment-15381028
 ] 

ASF GitHub Bot commented on NIFI-2157:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/645#discussion_r71074368
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
 ---
    @@ -184,23 +90,18 @@
                 
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
                 .build();
     
    -
    -    private final List<PropertyDescriptor> propDescriptors;
    -
    -    protected final Map<String, Integer> columnTypeMap = new HashMap<>();
    -
         public QueryDatabaseTable() {
             final Set<Relationship> r = new HashSet<>();
             r.add(REL_SUCCESS);
             relationships = Collections.unmodifiableSet(r);
     
             final List<PropertyDescriptor> pds = new ArrayList<>();
             pds.add(DBCP_SERVICE);
    +        pds.add(DB_TYPE);
             pds.add(TABLE_NAME);
             pds.add(COLUMN_NAMES);
             pds.add(MAX_VALUE_COLUMN_NAMES);
             pds.add(QUERY_TIMEOUT);
    -        pds.add(SQL_PREPROCESS_STRATEGY);
    --- End diff --
    
    Good point, agreed


> Add GenerateTableFetch processor
> --------------------------------
>
>                 Key: NIFI-2157
>                 URL: https://issues.apache.org/jira/browse/NIFI-2157
>             Project: Apache NiFi
>          Issue Type: Sub-task
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>             Fix For: 1.0.0
>
>
> This processor would presumably operate like QueryDatabaseTable, except it 
> will contain a "Partition Size" property, and rather than executing the SQL 
> statement(s) to fetch rows, it would generate flow files containing SQL 
> statements that will select rows from a table. If the partition size is 
> indicated, then the SELECT statements will refer to a range of rows, such 
> that each statement will grab only a portion of the table. If max-value 
> columns are specified, then only rows whose observed values for those columns 
> exceed the current maximum will be fetched (i.e. like QueryDatabaseTable). 
> These flow files (due to NIFI-1973) can be passed to ExecuteSQL processors 
> for the actual fetching of rows, and ExecuteSQL can be distributed across 
> cluster nodes and/or multiple tasks. These features enable distributed 
> incremental fetching of rows from database table(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to