[
https://issues.apache.org/jira/browse/NIFI-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397809#comment-15397809
]
ASF GitHub Bot commented on NIFI-2142:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r72658835
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -101,16 +101,16 @@
public static final PropertyDescriptor CACHE_SIZE = new
PropertyDescriptor.Builder()
.name("cache-size")
.displayName("Cache size")
- .description("Maximum size of the stylesheet cache.")
+ .description("Maximum number of stylesheets to cache. Zero
disables the cache.")
.required(true)
.defaultValue("100")
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
- public static final PropertyDescriptor CACHE_DURATION = new
PropertyDescriptor.Builder()
- .name("cache-duration")
- .displayName("Cache duration")
- .description("How long to keep stylesheets in the cache.")
+ public static final PropertyDescriptor CACHE_TTL_AFTER_LAST_ACCESS =
new PropertyDescriptor.Builder()
+ .name("cache-ttl-after-last-access")
+ .displayName("Cache TTL after last access")
+ .description("How long to keep stylesheets in the cache after
last access.")
--- End diff --
I like using TTL in the display name in order to make it more compact but
not every user may know what TTL means so it'd nice to have the explanation in
the description.
> Cache compiled XSLT in TransformXml
> -----------------------------------
>
> Key: NIFI-2142
> URL: https://issues.apache.org/jira/browse/NIFI-2142
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joey Frazee
> Fix For: 1.0.0
>
> Attachments: NIFI-2142 TransformXml Data Flow.png
>
>
> TransformXml appears to be recompiling the XSLT on every onTrigger event,
> which is slow. It should cache the compiled stylesheets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
