[
https://issues.apache.org/jira/browse/NIFI-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397814#comment-15397814
]
ASF GitHub Bot commented on NIFI-2142:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/609#discussion_r72659297
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -101,16 +101,16 @@
public static final PropertyDescriptor CACHE_SIZE = new
PropertyDescriptor.Builder()
.name("cache-size")
.displayName("Cache size")
- .description("Maximum size of the stylesheet cache.")
+ .description("Maximum number of stylesheets to cache. Zero
disables the cache.")
.required(true)
.defaultValue("100")
--- End diff --
This seems super high as a default number of stylesheets. I don't have much
experience with xml and stylesheets but I would think that the average user of
a default value wouldn't need to cache use more than 10. I will defer to your
experience with the xml and stylesheets if you think otherwise though.
> Cache compiled XSLT in TransformXml
> -----------------------------------
>
> Key: NIFI-2142
> URL: https://issues.apache.org/jira/browse/NIFI-2142
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joey Frazee
> Fix For: 1.0.0
>
> Attachments: NIFI-2142 TransformXml Data Flow.png
>
>
> TransformXml appears to be recompiling the XSLT on every onTrigger event,
> which is slow. It should cache the compiled stylesheets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
