[
https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413787#comment-15413787
]
Joseph Witt commented on NIFI-2521:
-----------------------------------
had an off-line discussion with Pierre to understand the origin of these
classes. He mentions it is sourced to SNMP4J but does agree the above cited
item calls that into question. The PR i've offered is a blunt instrument. It
kills off the questionable code but it leaves us with insufficient test
coverage. We could live with this for 1.0 but it would need to be corrected
later. Pierre mentions he will try to take a look at this evening. Have given
him the ticket. If we get close to cutting the 1.0 release and this is not
resolved then we can merge this PR as-is. For now let's see if Pierre can
provide alternative testing. Thanks [~pvillard]
> License and Notice - TestSNMPAgent classes appear to be copied from external
> sources
> ------------------------------------------------------------------------------------
>
> Key: NIFI-2521
> URL: https://issues.apache.org/jira/browse/NIFI-2521
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Assignee: Pierre Villard
> Priority: Blocker
> Fix For: 1.0.0, 0.8.0
>
>
> TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large
> part from https://code.google.com/archive/p/springside-sub/
> TestSNMPAgentV3 appears to be sourced from XYZ as found here
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68.
> These classes should be completely removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
