[ https://issues.apache.org/jira/browse/NIFI-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414114#comment-15414114 ]
Pierre Villard commented on NIFI-2521: -------------------------------------- [~joewitt] it clearly seems that there is more digging required from me to ensure we are safe here. Besides there is a unit test failing time to time. At this point, with releases coming, the safest way to move forward is to remove the tests. I'll submit a new PR shortly to address the tests of this bundle. In the meantime, the PR you submitted LGTM. +1 > License and Notice - TestSNMPAgent classes appear to be copied from external > sources > ------------------------------------------------------------------------------------ > > Key: NIFI-2521 > URL: https://issues.apache.org/jira/browse/NIFI-2521 > Project: Apache NiFi > Issue Type: Bug > Reporter: Joseph Witt > Assignee: Pierre Villard > Priority: Blocker > Fix For: 1.0.0, 0.8.0 > > > TestSNMPAgentV1 and TestSNMPAgentV2c appear to be sourced at least in large > part from https://code.google.com/archive/p/springside-sub/ > TestSNMPAgentV3 appears to be sourced from XYZ as found here > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/TestSnmpAgentV3.java#L68. > These classes should be completely removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)