[
https://issues.apache.org/jira/browse/NIFI-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423111#comment-15423111
]
ASF GitHub Bot commented on NIFI-2574:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/872#discussion_r74981298
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/groovy/org/apache/nifi/web/security/x509/ocsp/OcspCertificateValidatorGroovyTest.groovy
---
@@ -65,7 +65,8 @@ public class OcspCertificateValidatorGroovyTest {
@Before
public void setUp() throws Exception {
- mockProperties = [getProperty: { String propertyName -> return
"value_for_${propertyName}" }] as NiFiProperties
+ mockProperties = [getProperty: { String propertyName -> return
"value_for_${propertyName}"
+ ,getPropertyKeys: { -> return ["A", "set"] as Set<String>}] as
NiFiProperties
--- End diff --
Actually I'm getting weird errors, doesn't look like map coercion likes the
getProperty method, possibly because that method is used all over Groovy
meta-classes and such. This could replace the above:
mockProperties = new NiFiProperties() {
@Override
String getProperty(String key) {
return 'value_for_' + key
}
@Override
Set<String> getPropertyKeys() {
return ["A", "set"]
}
}
> Update NiFiProperties usage to a context based accessor rather than static
> singleton
> ------------------------------------------------------------------------------------
>
> Key: NIFI-2574
> URL: https://issues.apache.org/jira/browse/NIFI-2574
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Configuration, Core Framework
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 1.0.0
>
>
> This is a key step to move our longstanding odd static singleton usage of
> NiFiProperties which enables a loader to exist which will encapsulate all
> logic for dealing with encrypted properties as is the goal of the parent task.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
