[
https://issues.apache.org/jira/browse/NIFI-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424855#comment-15424855
]
ASF GitHub Bot commented on NIFI-2574:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/872#discussion_r75158697
--- Diff:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
---
@@ -29,17 +26,22 @@
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
-
-public class NiFiProperties extends Properties {
-
- private static final long serialVersionUID = 2119177359005492702L;
-
- private static final Logger LOG =
LoggerFactory.getLogger(NiFiProperties.class);
- private static NiFiProperties instance = null;
+import java.util.Set;
+
+/**
+ * The NiFiProperties class holds all properties which are needed for
various
+ * values to be available at runtime. It is strongly tied to the startup
+ * properties needed and is often refer to as the 'nifi.properties' file.
The
--- End diff --
should be "and is often referred to"
> Update NiFiProperties usage to a context based accessor rather than static
> singleton
> ------------------------------------------------------------------------------------
>
> Key: NIFI-2574
> URL: https://issues.apache.org/jira/browse/NIFI-2574
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Configuration, Core Framework
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Labels: migration
> Fix For: 1.0.0
>
>
> This is a key step to move our longstanding odd static singleton usage of
> NiFiProperties which enables a loader to exist which will encapsulate all
> logic for dealing with encrypted properties as is the goal of the parent task.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
